Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conda build: use the correct DockerHub credentials #1363

Merged
merged 3 commits into from Oct 29, 2020
Merged

Fix conda build: use the correct DockerHub credentials #1363

merged 3 commits into from Oct 29, 2020

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Oct 29, 2020 •
edited

@gsheni gsheni closed this Oct 29, 2020
@gsheni gsheni reopened this Oct 29, 2020
@codecov
Copy link

codecov bot commented Oct 29, 2020 •
edited

Codecov Report

Merging #1363 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1363   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         213      213           
  Lines       13857    13857           
=======================================
  Hits        13850    13850           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744c7b8...e49d40d. Read the comment docs.

@gsheni gsheni requested a review from dsherry October 29, 2020 14:10
@dsherry dsherry changed the title Update config.yml Update config.yml with DockerHub credentials Oct 29, 2020
dsherry
dsherry approved these changes Oct 29, 2020
View reviewed changes
.circleci/config.yml
@@ -59,7 +59,7 @@ commands:
cp -r `ls -A | grep -v "evalml-core-feedstock"` ./evalml-core-feedstock/evalml/
python .circleci/conda_config.py "$(python setup.py --version)"
cd evalml-core-feedstock
echo "$DOCKER_HUB_PASS" | docker login -u psalter --password-stdin
echo "$DOCKERHUB_PASSWORD" | docker login -u $DOCKERHUB_USERNAME --password-stdin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 omg I completely missed this yesterday. Thank you!

@dsherry dsherry changed the title Update config.yml with DockerHub credentials Fix conda build: use the correct DockerHub credentials Oct 29, 2020
@gsheni gsheni merged commit 4aa95d3 into main Oct 29, 2020
@gsheni gsheni deleted the update_conda_docker_credentials branch October 29, 2020 14:24
@dsherry dsherry mentioned this pull request Oct 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CircleCI: auth needed for Docker Hub as of Nov 1st
2 participants
@gsheni @dsherry